Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New build task : paketo builder #1660

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

cmoulliard
Copy link
Contributor

@cmoulliard cmoulliard commented Nov 28, 2024

  • New build task: paketo builder
  • The build-paketo-ubi-builder task builds the ubi builder image for paketo using as input the builder.toml file. The image is build using the pack tool packaged part of the paketo-container image.
    The task also produces the SBOM which is signed and added to the image.

Build succeeded part of this PR: https://console.redhat.com/application-pipeline/workspaces/cmoullia/applications/buildpack-remote/pipelineruns/builder-ubi-base-l2q8r

Screenshot 2024-11-28 at 15 46 54

@mmorhun
Copy link
Collaborator

mmorhun commented Nov 29, 2024

@cmoulliard what are the obstacles to use common buildah(-remote) task?

@cmoulliard
Copy link
Contributor Author

what are the obstacles to use common buildah(-remote) task?

What do you mean by "to use common buildah task" ? If the question is about: "Can we build the ubi builder image using buildah then the answer is no as such an image is not build from a Dockerfile by using a tool: pack - https://github.com/buildpacks/pack"

@mmorhun
Copy link
Collaborator

mmorhun commented Nov 29, 2024

@cmoulliard have you considered running pack inside a build stage and just copying the content to the final stage?

@cmoulliard
Copy link
Contributor Author

have you considered running pack inside a build stage and just copying the content to the final stage?

What is a build stage ? Can you elaborate ?

@mmorhun
Copy link
Collaborator

mmorhun commented Dec 2, 2024

What is a build stage ? Can you elaborate ?

Sorry for not being clear enough, I meant this

@MartinBasti
Copy link
Contributor

/verify-owners

@cmoulliard
Copy link
Contributor Author

Sorry for not being clear enough, I meant this

Thanks. We cannot use Dockerfile like Multi-stage to build the buildpack stuffs (builder image or stack image or buildpacks) but specific tools like: pack, jam, create-package, etc

@MartinBasti
Copy link
Contributor

/verify-owners

@arewm
Copy link
Member

arewm commented Dec 4, 2024

/retest

@cmoulliard
Copy link
Contributor Author

Can we merge it ?

@MartinBasti
Copy link
Contributor

Can we merge it ?

No, it has no approvals and unresolved threads

@chmeliik
Copy link
Contributor

chmeliik commented Dec 6, 2024

We have changed the ownership mechanism from OWNERS to CODEOWNERS. Please rebased on main and update CODEOWNERS instead of OWNERS 🙏

@cmoulliard cmoulliard requested a review from a team as a code owner December 9, 2024 08:39
@MartinBasti
Copy link
Contributor

Please squash commits into one with nice description

@cmoulliard cmoulliard force-pushed the paketo-builder branch 2 times, most recently from 471a178 to 05e7400 Compare December 13, 2024 16:38
@cmoulliard
Copy link
Contributor Author

Please squash commits into one with nice description

Done @MartinBasti

@MartinBasti
Copy link
Contributor

05e7400 this is not a nice description, in neither of commits. (Why it has 2 commits?)

https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/

@cmoulliard
Copy link
Contributor Author

(Why it has 2 commits?)

My fault. I missed one commit

@cmoulliard
Copy link
Contributor Author

PR needs rebase.

Label to rebase has been removed. Should I do then rebase ?
Screenshot 2024-12-16 at 15 00 17

@MartinBasti
Copy link
Contributor

yes rebase, it won't hurt

@cmoulliard
Copy link
Contributor Author

yes rebase, it won't hurt

Sorry but I'm not a specialist to squash. If I git rebase -i HEAD~4, do next pick/squash, write/quit then I got a conflict with the renovate.js file which don't exist top of this PR ...

@tkdchen
Copy link
Contributor

tkdchen commented Dec 17, 2024

There seems no code conflict, then probably you can try these steps:

  • update local main branch
  • create a new branch
  • cherry-pick the three commits in this PR
  • force pushing to update this PR

@cmoulliard
Copy link
Contributor Author

There seems no code conflict, then probably you can try these steps:

I created a new branch containing the commits and merged them into one => https://github.com/redhat-buildpacks/fork-konflux-build-definitions/tree/new-paketo-builder
but I don't know how to push it on this PR. Can you help me ? @tkdchen

@tkdchen
Copy link
Contributor

tkdchen commented Dec 17, 2024

There seems no code conflict, then probably you can try these steps:

I created a new branch containing the commits and merged them into one => https://github.com/redhat-buildpacks/fork-konflux-build-definitions/tree/new-paketo-builder but I don't know how to push it on this PR. Can you help me ? @tkdchen

git checkout new-paketo-builder
git push --force HEAD:paketo-builder

❗ Before doing the force push, please ensure the new branch have all the necessary code because the force push will overwrite the paketo-builder branch completely.

@cmoulliard
Copy link
Contributor Author

cmoulliard commented Dec 17, 2024

❗ Before doing the force push, please ensure the new branch have all the necessary code because the force push will overwrite the paketo-builder branch completely.

I did a test successfully on konflux with the pipeline consuming the task of this PR from code pushed from the branch: new-paketo-builder @tkdchen

Signed-off-by: cmoulliard <[email protected]>
@cmoulliard
Copy link
Contributor Author

/retest

Copy link
Contributor

@MartinBasti MartinBasti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail seems unrelated, I'll try to look at it

@MartinBasti
Copy link
Contributor

/retest

@MartinBasti MartinBasti added this pull request to the merge queue Dec 18, 2024
Merged via the queue into konflux-ci:main with commit 9412a5f Dec 18, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants