-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New build task : paketo builder #1660
New build task : paketo builder #1660
Conversation
@cmoulliard what are the obstacles to use common buildah(-remote) task? |
What do you mean by "to use common buildah task" ? If the question is about: "Can we build the ubi builder image using buildah then the answer is no as such an image is not build from a Dockerfile by using a tool: pack - https://github.com/buildpacks/pack" |
@cmoulliard have you considered running |
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-ubi-builder/0.1/build-paketo-ubi-builder.yaml
Outdated
Show resolved
Hide resolved
What is a build stage ? Can you elaborate ? |
Sorry for not being clear enough, I meant this |
/verify-owners |
Thanks. We cannot use Dockerfile like Multi-stage to build the buildpack stuffs (builder image or stack image or buildpacks) but specific tools like: pack, jam, create-package, etc |
/verify-owners |
/retest |
Can we merge it ? |
task/build-paketo-builder-oci-ta/0.1/build-paketo-builder-oci-ta.yaml
Outdated
Show resolved
Hide resolved
task/build-paketo-builder-oci-ta/0.1/build-paketo-builder-oci-ta.yaml
Outdated
Show resolved
Hide resolved
No, it has no approvals and unresolved threads |
We have changed the ownership mechanism from OWNERS to CODEOWNERS. Please rebased on main and update CODEOWNERS instead of OWNERS 🙏 |
770b26a
to
abe1ba5
Compare
task/build-paketo-builder-oci-ta/0.1/build-paketo-builder-oci-ta.yaml
Outdated
Show resolved
Hide resolved
Please squash commits into one with nice description |
471a178
to
05e7400
Compare
Done @MartinBasti |
05e7400 this is not a nice description, in neither of commits. (Why it has 2 commits?) https://www.freecodecamp.org/news/how-to-write-better-git-commit-messages/ |
My fault. I missed one commit |
yes rebase, it won't hurt |
Sorry but I'm not a specialist to squash. If I |
There seems no code conflict, then probably you can try these steps:
|
Signed-off-by: cmoulliard <[email protected]>
I created a new branch containing the commits and merged them into one => https://github.com/redhat-buildpacks/fork-konflux-build-definitions/tree/new-paketo-builder |
git checkout new-paketo-builder
git push --force HEAD:paketo-builder ❗ Before doing the force push, please ensure the new branch have all the necessary code because the force push will overwrite the |
80a9dc6
to
62e847c
Compare
I did a test successfully on konflux with the pipeline consuming the task of this PR from code pushed from the branch: |
Signed-off-by: cmoulliard <[email protected]>
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI fail seems unrelated, I'll try to look at it
/retest |
build-paketo-ubi-builder
task builds the ubi builder image for paketo using as input the builder.toml file. The image is build using the pack tool packaged part of the paketo-container image.The task also produces the SBOM which is signed and added to the image.
Build succeeded part of this PR: https://console.redhat.com/application-pipeline/workspaces/cmoullia/applications/buildpack-remote/pipelineruns/builder-ubi-base-l2q8r